Skip to content

[12.x] Add missing @throws annotation to Number #56116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

AhmedAlaa4611
Copy link
Contributor

Description

This PR adds the @throws RuntimeException annotation to the protected ensureIntlExtensionIsInstalled() method in Illuminate\Support\Number.

I did not used @throws \RuntimeException because we used use RuntimeException; at the beginning of the file.

@cosmastech
Copy link
Contributor

I'm pretty sure that the code style is to always use the fully qualified namespaces inside of docblocks.

@taylorotwell taylorotwell merged commit 3c0aacc into laravel:12.x Jun 23, 2025
60 checks passed
mohammad-fouladgar pushed a commit to mohammad-fouladgar/framework that referenced this pull request Jul 22, 2025
* Add missing @throws annotation to Number

* Update Number.php

---------

Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants