[12.x] fix: Models having inconsistent guarding behaviour #56381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a unit test to cover edge cases where models exhibit inconsistent behaviour when the $guard property is empty but the $fillable is not. A MassAssignmentException is thrown. this happens because getGuarded in GuardsAttributes has two different mechanisms for unguarding a model. 1. $unguarded boolean property (default: false) 2. $guarded array property (default: ['*']) `getGuarded()` uses the $guarded and checks if it's false to return and empty array. `fillableFromArray()` uses $unguarded and $fillable properties to test if the model is unguarded. Both methods should use $unguarded for consistent behaviour.
JimTools
force-pushed
the
bugfix/model-guard-with-fillable
branch
from
170ac1f to
2402d8e
Compare
JimTools
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue with the Models having inconsistent guarding behaviour when
$guardedis empty, but$fillableis populated, which causes a MassAssignmentException to be thrown. this happens becausegetGuardedinGuardsAttributeshas two different mechanisms for unguarding a model.getGuarded()uses the$guardedand checks if it's false to return an empty array.fillableFromArray()uses$unguardedand$fillableproperties to test if the model is unguarded.Both methods should use $unguarded for consistent behaviour.
closes #56380