Skip to content

[12.x] Reverts 56310 #56408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

[12.x] Reverts 56310 #56408

merged 1 commit into from
Jul 25, 2025

Conversation

AhmedAlaa4611
Copy link
Contributor

Description

This PR reverts the changes introduced in #56310, as it broke the output formatting when calling a seeder from within another seeder.

For example, the following code:

<?php

namespace Database\Seeders;

use App\Models\User;
use Illuminate\Database\Seeder;

class DatabaseSeeder extends Seeder
{
    /**
     * Seed the application's database.
     */
    public function run(): void
    {
        $this->call([
            UserSeeder::class,
        ]);
    }
}

Produces incorrect or undesirable output, as shown below:

Screenshot 2025-07-25 084220

Given this regression, reverting to the previous behavior is more appropriate. The original implementation handled nested seeders more gracefully.

@amirhshokri
Copy link
Contributor

Since I had previously suggested enhancing this part and it wasn’t accepted, I think reverting it could also be a good option.

@taylorotwell taylorotwell merged commit 090a083 into laravel:12.x Jul 25, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants