Skip to content

Add missing parameters to isUrl and isUuid #56453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2025
Merged

Add missing parameters to isUrl and isUuid #56453

merged 1 commit into from
Jul 27, 2025

Conversation

brufdev
Copy link
Contributor

@brufdev brufdev commented Jul 27, 2025

This pull request fixes missing parameters in the isUrl and isUuid methods of the Stringable class and adds corresponding tests.

Currently, these calls are valid but should not be, because the methods do not respect the provided parameters:

Str::of('https://laravel.com')->isUrl(['http']); // should return false, but returns true
Str::of('2cdc7039-65a6-4ac7-8e5d-d554a98e7b15')->isUuid(7); // should return false, but returns true

@taylorotwell taylorotwell merged commit c890a83 into laravel:12.x Jul 27, 2025
62 checks passed
This was referenced Aug 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brufdev @taylorotwell