fix(postgres): resolve enum column change syntax error #56523
+104
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL enum column changes were failing with syntax errors because
Laravel was generating invalid SQL that included CHECK constraints in
ALTER COLUMN TYPE statements.
Changes:
- Modified PostgresGrammar::typeEnum() to return only varchar(255) for
ALTER COLUMN contexts, avoiding inline CHECK constraints
- Enhanced PostgresGrammar::compileChange() to handle enum columns with
separate statements: DROP old constraint, ALTER column type, ADD new constraint
- Added comprehensive tests for PostgreSQL enum column changes
Fixes the error: "syntax error at or near 'check'" when changing enum
column definitions in PostgreSQL migrations.
Before:
ALTER COLUMN "status" TYPE varchar(255) check ("status" in (...)) -- INVALID
After:
DROP CONSTRAINT IF EXISTS table_column_check;
ALTER COLUMN "status" TYPE varchar(255);
ADD CONSTRAINT table_column_check CHECK ("status" in (...)); -- VALID
PostgreSQL may return different column type names (e.g., 'varchar' vs 'character varying', 'int4' vs 'integer') depending on configuration. Updated assertions to use assertContains with arrays of valid type names to ensure tests pass consistently across different PostgreSQL setups.
|
@hafezdivandari what do you think about this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL enum column changes were failing with syntax errors because Laravel was generating invalid SQL that included CHECK constraints in ALTER COLUMN TYPE statements.
Changes:
Fixes the error: "syntax error at or near 'check'" when changing enum column definitions in PostgreSQL migrations.
Before:
ALTER COLUMN "status" TYPE varchar(255) check ("status" in (...)) -- INVALID
After:
DROP CONSTRAINT IF EXISTS table_column_check;
ALTER COLUMN "status" TYPE varchar(255);
ADD CONSTRAINT table_column_check CHECK ("status" in (...)); -- VALID