feat(arm64): create docker image for mkimage-iso-bios (amd64 toolsuite)#4103
feat(arm64): create docker image for mkimage-iso-bios (amd64 toolsuite)#4103SmartArray wants to merge 2 commits intolinuxkit:masterfrom
mkimage-iso-bios (amd64 toolsuite)#4103Conversation
|
Oh, oh, I like this. We never did it because it always was x86 (BIOS is x86 only, as opposed to arm64, which is UEFI, as you pointed out), but there is no reason you should not be able to build for x86 while on arm64 (or riscv64). Please do the following:
|
|
Oh yeah, and remove from "draft" |
|
@deitch The PR is in draft mode because I could need your advice on what output formats did not work on arm64. And whether there is a different architecture you would like me to check. Thanks for pointing out the contributing guidelines. I will do it right away |
25e6aa9 to
51ab94a
Compare
|
I checked the other ones, it seems that we should leave it with |
e0c41c9 to
24d4166
Compare
|
Here we go. Everything should be ready for review now. |
|
One of the commits isn't signed. Either sign that one, too, or squash them to a single signed commit, please. |
e0b2a8a to
812a9f1
Compare
|
Here we go! |
|
The DCO still is failing. Please check how to pass it here |
Signed-off-by: Yoshi Jaeger <github@jaeger.berlin>
Signed-off-by: Yoshi Jaeger <github@jaeger.berlin>
bffdefe to
492e689
Compare
|
Weird, I think it was due to the missing Signed-Off message. The DCO check seems to be valid now, but there is no verified tag next to my commit. Is that expected? |
|
Looks good to me. We don't actually exercise it as part of CI (the tests there mostly use UEFI), so please confirm that you did a build and booted it successfully. |
|
Tests are failing because |
|
Pushed out, restarted failing tests. Let's see if CI is clean. |
|
Getting failure here. Did you forget to copy over some dependencies? |
|
Thanks for your time I see this And that's confusing because all we did was removing syslinux dep.
So that points to the fact that Edit: Yes, I just verified this. So if we add libuuid to the list of deps, we should be fine (works on all platforms) |
|
Yes I think that makes sense. The current method was Might be worth running a test manually. Build this locally and try to run syslinux and see what dependencies are missing before pushing out again. |

- What I did
This is a WIP PR. I am using this great project on my M1 Mac and I noticed a couple of output formats are not working since they rely on syslinux alpine dependency.
I checked for what we are using the dependency and it only seemed to be the BIOS bootloader file, and the boot process. Since those are only being used to build the ISO image, this should be fine.
Note that the resulting image cannot run on arm64 systems, but only amd64, since the boot process is using AMD64 opcodes.
Warning
Dear maintainers, please verify if this is useful at all, because maybe people would expect to be able to create arm64 ISO images. However, it is common knowledge that arm64 commonly uses UEFI instead of BIOS for booting. So I hope this Pull Request is useful.
I put this PR into WIP, because we might be able to apply this for other output formats too. However, I haven't checked them yet.
- How I did it
I removed the syslinux dependency and introduced a multistage build, in which I pull the amd64 version of alpine and copy the required files
- How to verify it
Create ISO-bios image on M1-M3 Mac. It should be able to create an ISO image.
- Description for the changelog
Add output support for amd64 architecture
- A picture of a cute animal (not mandatory but encouraged)
