Fix missing symbol in HTML generation of metrics coverage report #11668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ silv-io can you review this PR? |
silv-io
added
the
semver: patch
silv-io
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Hi @vignesh1507, sorry for not getting back to you sooner, I didn't receive the ping because of the space between my user name and the @.
The change looks good to me, so I'll merge it right away!
silv-io
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small issue in the HTML generation section at the end of the
create_readable_reportfunction. The closing>for the lastfd.write("</body></html")is missing. It should befd.write("</body></html>").