Update cbor 2 requirement to 5.5 #11704
Conversation
Currently cbor is listed as required for >= 5.2 localstack@b612563 relies on the existence of `cbor2._decoder` which appears first in cbor 5.5 https://github.com/agronholm/cbor2/tree/5.5.0/cbor2 notice its absence here https://github.com/agronholm/cbor2/tree/5.4.6/cbor2
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
I know i'm supposed to add a label, it should be semver: patch but i can't figure out how to add it :/ |
dfangl
added
the
semver: patch
|
I have read the CLA Document and I hereby sign the CLA |
|
@hammer498 I am terribly sorry that I overlooked this contribution! Thanks a lot for the proactive approach! I already fixed this with #12051. I'll try to merge this either way, let's see if we can still merge this one to give you the credits. |
Currently cbor is listed as required for >= 5.2
b612563 relies on the existence of
cbor2._decoderwhich appears first in cbor 5.5 https://github.com/agronholm/cbor2/tree/5.5.0/cbor2 notice its absence herehttps://github.com/agronholm/cbor2/tree/5.4.6/cbor2
Motivation
#11703
more accurately reflects requirements