Skip to content

upgrade outdated github action in ASF update workflow #11975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

alexrashed
Copy link
Member

Motivation

This PR upgrades the version of mad9000/actions-find-and-replace-string.
This action is somehow not updated by dependabot, which is why we are doing it manually to avoid issues in the future (GitHub is has deprecated Node 16 support a long time ago):
image

Changes

  • Upgrades mad9000/actions-find-and-replace-string to version 5

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Dec 3, 2024
@alexrashed alexrashed added this to the 4.1 milestone Dec 3, 2024
@alexrashed alexrashed self-assigned this Dec 3, 2024
@alexrashed alexrashed marked this pull request as ready for review December 3, 2024 11:37
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Question: do we know why dependabot is not updating the version of this action?

@alexrashed alexrashed merged commit 0ae976e into master Dec 4, 2024
28 checks passed
@alexrashed alexrashed deleted the upgrade-outdated-github-action branch December 4, 2024 08:50
@alexrashed
Copy link
Member Author

That's a really good question, I tried to dig into this issue, but couldn't find anything.
I filed an issue in the action repo to follow up on this: mad9000/actions-find-and-replace-string#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants