Allow usage of additional runtimes with the Lambda SnapStart feature enabled #12006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrently does (not only the officially supported ones)
dfangl
added
the
semver: patch
dfangl
requested review from
joe4dev,
dominikschubert and
gregfurman
as code owners
joe4dev
approved these changes
Dec 9, 2024
| def test_snapstart_update_function_configuration( | ||
| self, create_lambda_function, snapshot, aws_client, runtime | ||
| self, multiruntime_lambda, snapshot, aws_client |
| "EphemeralStorage": { | ||
| "Size": 512 | ||
| }, | ||
| "FunctionArn": "arn:<partition>:lambda:<region>:111111111111:function:<function-name:1>", | ||
| "FunctionName": "<function-name:1>", | ||
| "Handler": "cloud.localstack.sample.LambdaHandlerWithLib", |
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 30m 1s ⏱️ - 21m 55s Results for commit b9ad6eb. ± Comparison against base commit eaf1a15. This pull request removes 949 and adds 35 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recently, AWS announced support for additional runtimes for using SnapStart: https://aws.amazon.com/blogs/aws/aws-lambda-snapstart-for-python-and-net-functions-is-now-generally-available/
However, while investigating this change, it seems that over the API the feature is available for all runtimes, not just the announced ones.
Whether this is a temporary error, or a hint that additional runtimes could get supported in the future, I removed the runtime validation for snapstart creation and updates, and added aws-validated tests for all runtimes to show it is indeed possible to create them.
I did some more investigation, and it seems like SnapStart is even (somewhat) functioning, at least an initial initialization of the function potentially takes place (if you misconfigure the function, it errors out immediately, it does not do so without snapstart enabled).
Changes