Skip to content

Unskip supported Lambda and ESM tests #12012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 16, 2024
Merged

Unskip supported Lambda and ESM tests #12012

merged 5 commits into from
Dec 16, 2024

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Dec 10, 2024

Motivation

With the many Lambda and ESM v2 improvements, we can unskip tests and enable snapshot validations.

Changes

  • Unskip supported Lambda and ESM tests

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Dec 10, 2024
@joe4dev joe4dev self-assigned this Dec 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 30m 58s ⏱️ - 21m 46s
2 944 tests  - 949  2 736 ✅  - 847  208 💤  - 102  0 ❌ ±0 
2 946 runs   - 949  2 736 ✅  - 847  210 💤  - 102  0 ❌ ±0 

Results for commit 46fac99. ± Comparison against base commit 630f782.

This pull request removes 950 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.stepfunctions.v2.scenarios.test_base_scenarios.TestBaseScenarios ‑ test_map_state_nested_config_distributed

♻️ This comment has been updated with latest results.

joe4dev
joe4dev commented Dec 11, 2024
View reviewed changes
tests/aws/services/cloudformation/resources/test_lambda.py
@markers.snapshot.skip_snapshot_verify(paths=["$..CodeSize"])
@markers.snapshot.skip_snapshot_verify(
paths=[
# Lambda ZIP flaky in CI
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfangl @dominikschubert Is that assumption correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually yes, we cannot totally rely on this, as it might change.

@joe4dev joe4dev marked this pull request as ready for review December 11, 2024 14:55
pinzon
pinzon reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many unskipped snapshots attributes and tests 🥳

tests/aws/services/cloudformation/resources/test_lambda.py
Comment on lines +56 to +58
# TODO: Fix flaky ESM state mismatch upon update in LocalStack (expected Enabled, actual Disabled)
# This might be a parity issue if AWS does rolling updates (i.e., never disables the ESM upon update).
"$..EventSourceMappings..State",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe4dev joe4dev force-pushed the unskip-supported-lambda-esm-tests branch from ca5538a to 376b6a9 Compare December 13, 2024 08:48
dfangl
dfangl approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor confusion in a validation file!

tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_kinesis.snapshot.json
@@ -233,7 +234,7 @@
"partitionKey": "test_0",
"sequenceNumber": "<sequence-number:1>",
"data": "eyJyZWNvcmRfaWQiOiAwfQ==",
"approximateArrivalTimestamp": "timestamp"
"approximateArrivalTimestamp": "<approximate-arrival-timestamp>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get the timestamp - format - matching here in the future!

tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_kinesis.validation.json Outdated
@@ -75,3 +73,9 @@
"last_validated_date": "2024-10-12T13:23:12+00:00"
}
}
"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a " in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the entire validations file was messed up 😆
Re-generated from scratch ✅

@joe4dev joe4dev merged commit 69ddfef into master Dec 16, 2024
31 checks passed
@joe4dev joe4dev deleted the unskip-supported-lambda-esm-tests branch December 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon left review comments

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@gregfurman gregfurman Awaiting requested review from gregfurman

@simonrw simonrw Awaiting requested review from simonrw

Assignees

@joe4dev joe4dev

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe4dev @dfangl @pinzon