CloudFormation, Fix Retrieval of State Machine Definitions On Stack Update #12044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
added
the
semver: minor
MEPalma
requested review from
joe4dev,
dominikschubert,
gregfurman,
pinzon and
simonrw
as code owners
1 task
pinzon
approved these changes
Dec 17, 2024
tests/aws/services/cloudformation/resources/test_stepfunctions.py
Outdated
Show resolved
Hide resolved
tests/aws/services/cloudformation/resources/test_stepfunctions.py
Outdated
Show resolved
Hide resolved
tests/aws/services/cloudformation/resources/test_stepfunctions.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, CloudFormation encounters issues when updating state machines during StackUpdate operations, as it incorrectly assumes the state machine definition is always provided as a literal in the DefinitionString field. This assumption causes errors when using alternative methods for defining state machines, such as through DefaultS3Location #11255.
This update introduces tests for CloudFormation templates that create state machines using DefaultS3Location and ensures that during stack updates, the definition string is correctly extracted by sampling the available alternatives.
Changes