Skip to content

Improve error message for a missing parameter value - provide its name #12086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

Improve error message for a missing parameter value - provide its name #12086

merged 1 commit into from
Jan 4, 2025

Conversation

asomov
Copy link
Contributor

@asomov asomov commented Jan 2, 2025 •
edited
Loading

Motivation

Improve error message

Changes

Provide the name of the parameter without a value

Testing

Not tested - I do not know how to run tests

semver: patch

@asomov
Copy link
Contributor Author

asomov commented Jan 2, 2025 •
edited
Loading

What is this and how to fix it:
Error: Label error. Requires exactly 1 of: semver: patch, semver: minor, semver: major. Found:
I have read the guideline, but I do not get how to set the semver label

@asomov
Copy link
Contributor Author

asomov commented Jan 2, 2025

The ticket:
#12088

@pinzon pinzon added the semver: patch Non-breaking changes which can be included in patch releases label Jan 2, 2025
pinzon
pinzon approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

simonrw
simonrw approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, our error messages could definitely do with some work and this is an improvement. I have some minor suggestions about the wording but I think the change is fine as it is. I will merge this. Thanks again!🎉

@simonrw simonrw added semver: patch Non-breaking changes which can be included in patch releases and removed semver: patch Non-breaking changes which can be included in patch releases labels Jan 4, 2025
@simonrw simonrw self-assigned this Jan 4, 2025
@simonrw simonrw merged commit c3f72f7 into localstack:master Jan 4, 2025
35 of 38 checks passed
@asomov asomov deleted the improve-error-message-patch branch January 5, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@simonrw simonrw

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asomov @simonrw @pinzon