Skip to content

fix template body when using CFN create-stack #12097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix template body when using CFN create-stack #12097

merged 2 commits into from
Jan 6, 2025

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Jan 2, 2025

Motivation

As detected by a Customer, CloudFormation Get-Template always returns the stack template in JSON format even when using a YAML template. This is a mistake which the PR fixes

Changes

  • avoid transforming the the template body to JSON
  • add test for the get-template operation after a create-stack call
  • rename the previous test of the feature
  • Remove old snapsshots.

@pinzon pinzon added the semver: patch Non-breaking changes which can be included in patch releases label Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

LocalStack Community integration with Pro

  2 files    2 suites   20m 13s ⏱️
418 tests 307 ✅ 111 💤 0 ❌
420 runs  307 ✅ 113 💤 0 ❌

Results for commit b8ca9e1.

@pinzon pinzon marked this pull request as ready for review January 2, 2025 20:11
simonrw
simonrw approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, I'm surprised though that customers are relying on the format of the template but I suppose they may do their own parsing or something. I'm glad we have better parity here, thanks!

@pinzon pinzon merged commit b829400 into master Jan 6, 2025
31 checks passed
@pinzon pinzon deleted the cloudformation/fix-template-body branch January 6, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @simonrw