APIGW: fix OpenAPI import StatusCode string casting #12137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:apigateway
bentsku
commented
Jan 20, 2025
| "responseParameters": { | ||
| "method.response.header.Access-Control-Allow-Origin": "'*'" | ||
| }, | ||
| "statusCode": "200", |
There was a problem hiding this comment.
before the fix, this would have been an int and fail with some typed languages trying to decode the response
bentsku
force-pushed
the
fix-apigw-get-resources
branch
2 times, most recently
from
abf0057 to
9198503
Compare
bentsku
force-pushed
the
fix-apigw-get-resources
branch
from
9198503 to
24ef95f
Compare
simonrw
approved these changes
Jan 22, 2025
bentsku
force-pushed
the
fix-apigw-get-resources
branch
from
24ef95f to
6343abc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We got a report that importing a specific OpenAPI file in API Gateway v1 would result in a type error in OpenTOFU:
This is because we were not casting as string the status code for the Method status code, and the IntegrationResponse.
When importing an API, we do so by creating the resources "in memory" directly and not via API calls, as this was how on the implementation was. This particular piece of code needs to be reworked fully, but this is out of scope of this PR.
Changes