Skip to content

adjust --follow arg positioning to be compatible with docker and podman #12200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

adjust --follow arg positioning to be compatible with docker and podman #12200

merged 1 commit into from
Jan 29, 2025

Conversation

cfeller
Copy link
Contributor

@cfeller cfeller commented Jan 29, 2025 •
edited
Loading

Motivation

As described in this issue:
#12201

localstack fails to log under podman. Before this PR, starting logstack when using podman will reach the following error:

⠼ Starting LocalStack container2025-01-28T19:11:00.121 DEBUG --- [-log-printer] localstack.utils.run       : Executing command: ['docker', 'logs', '261b4f90dcc37e74bce5b97cf390a7b935fc2d1e0d12ecd41c8df632b7587e76', '--follow']          
────────────────────────────────────────────────────────────────────────────────── LocalStack Runtime Log (press CTRL-C to quit) ───────────────────────────────────────────────────────────────────────────────────
Error: no container with name or ID "--follow" found: no such container

and logging will stop.

technically localstack will start, but no further console logs are produced after the above error.

In short, podman appears to be sensitive to the position of the -f or --follow argument. Moving the argument before the container id is compatible with both docker and podman

Changes

localstack will now start without generating a logging error under podman, allowing console logs to be followed.

@localstack-bot
Copy link
Contributor

localstack-bot commented Jan 29, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

localstack-bot
localstack-bot reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@cfeller
Copy link
Contributor Author

cfeller commented Jan 29, 2025

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Jan 29, 2025
@localstack-bot
@cfeller has signed the CLA in #12200
5581391
@cfeller cfeller mentioned this pull request Jan 29, 2025
Closed
1 task
@cfeller
Copy link
Contributor Author

cfeller commented Jan 29, 2025

Corresponding issue created here:
#12201

@cfeller
Copy link
Contributor Author

cfeller commented Jan 29, 2025

Per the contributing doc, it appears I need to add the semver: patch label, but I don't seem to have the permissions to do so.

@silv-io silv-io added this to the Playground milestone Jan 29, 2025
@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jan 29, 2025
dfangl
dfangl approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very reasonable change, thank you for your contribution!
This change will be part of the released CLI with the next minor release, which is scheduled for tomorrow!

@dfangl dfangl modified the milestones: Playground, 4.1 Jan 29, 2025
@dfangl dfangl merged commit 6d9597a into localstack:master Jan 29, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@cfeller @localstack-bot @dfangl @silv-io