Skip to content

Step Functions: remove config variables for legacy provided removed in v4.0 #12492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Step Functions: remove config variables for legacy provided removed in v4.0 #12492

merged 2 commits into from
Apr 9, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Apr 7, 2025 •
edited
Loading

Motivation

The legacy Step Functions provider was removed in version 4.0. However, some related configuration options, LOCAL_PORT_STEPFUNCTIONS and STEPFUNCTIONS_LAMBDA_ENDPOINT, were left behind in the codebase. Neither of these environment variables is currently in use. In LocalStack's docs STEPFUNCTIONS_LAMBDA_ENDPOINT is already correctly documented as a legacy optionLOCAL_PORT_STEPFUNCTIONS is not listed.

Changes

  • Removed LOCAL_PORT_STEPFUNCTIONS and STEPFUNCTIONS_LAMBDA_ENDPOINT

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Apr 7, 2025
@MEPalma MEPalma added this to the 4.4 milestone Apr 7, 2025
@MEPalma MEPalma requested a review from joe4dev April 7, 2025 07:38
@MEPalma MEPalma self-assigned this Apr 7, 2025
@MEPalma MEPalma requested a review from thrau as a code owner April 7, 2025 07:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   8m 31s ⏱️
488 tests 438 ✅  50 💤 0 ❌
976 runs  876 ✅ 100 💤 0 ❌

Results for commit 080b4fb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 51m 32s ⏱️ +47s
4 328 tests +3  3 978 ✅  - 3  344 💤 ±0  0 ❌ ±0  6 🔥 +6 
4 330 runs  +3  3 978 ✅  - 3  346 💤 ±0  0 ❌ ±0  6 🔥 +6 

For more details on these errors, see this check.

Results for commit 080b4fb. ± Comparison against base commit 7dc21bd.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma requested review from anisaoshafi and removed request for thrau April 9, 2025 08:59
anisaoshafi
anisaoshafi approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@anisaoshafi anisaoshafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹🏠

(kind reminder to adjust/remove these variable in case they appear in any public docs)

joe4dev
joe4dev approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add them to deprecations.py to pro-actively inform the user (requires keeping the list in CONFIG_ENV_VARS) or is the provider deprecation warning sufficient?

@MEPalma
Copy link
Contributor Author

MEPalma commented Apr 9, 2025

Thank you! I have reported the changes also in deprecations.py. The recommendation there is to mirror the deprecations in the docs https://docs.localstack.cloud/references/configuration/. There, the description for LOCAL_PORT_STEPFUNCTIONS is missing; I'll address this discrepancy there too.

@MEPalma MEPalma merged commit 9e03371 into master Apr 9, 2025
36 of 38 checks passed
@MEPalma MEPalma deleted the MEP-SFN-rm_legacy_envvar branch April 9, 2025 13:15
@MEPalma MEPalma mentioned this pull request Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@anisaoshafi anisaoshafi anisaoshafi approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MEPalma @joe4dev @anisaoshafi