Switch to using kclpy-ext
#12567
Merged
Switch to using kclpy-ext
#12567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silv-io
added
the
semver: patch
silv-io
force-pushed
the
switch-to-kclpy-ext
branch
from
a923ac6 to
3cfcda7
Compare
dfangl
approved these changes
May 5, 2025
simonrw
pushed a commit
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We repeatedly run into issues of kclpy wheels not being able to build inside of our pipelines (in the Docker build). This is because kclpy needs to download JARs from maven and there is no built wheel including those JARs available in PyPI.
However, we can just create and publish that wheel once ourselves and then use our own published package/wheel instead - therefore not relying on maven anymore.
Changes
amazon-kclpytokclpy-ext, which we build and publish in the https://github.com/localstack/amazon-kinesis-client-python repo.Testing
The existing kinesis test suite should handle this sufficiently. After all, this should be the exact same package, just with a pre-built wheel available