CFNv2: support dynamic parameter resolution #12797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: minor
simonrw
force-pushed
the
cfn/v2/dynamic-ssm-lookup
branch
from
acc5133 to
6574897
Compare
MEPalma
reviewed
Jun 26, 2025
| @@ -1040,7 +1045,23 @@ def visit_node_array(self, node_array: NodeArray) -> PreprocEntityDelta: | |||
| return PreprocEntityDelta(before=before, after=after) | |||
|
|
|||
| def visit_node_property(self, node_property: NodeProperty) -> PreprocEntityDelta: | |||
| return self.visit(node_property.value) | |||
| # TODO: is this the right place? | |||
There was a problem hiding this comment.
Are dynamic parameters only resolved at a property level? For example, these are never resolved as input for another intrinsic function?
simonrw
force-pushed
the
cfn/v2/describe-parameters
branch
from
6c4cd17 to
2ac855d
Compare
pinzon
approved these changes
Jul 22, 2025
| @@ -394,7 +394,7 @@ def test_create_change_set_missing_stackname(aws_client): | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip("CFNV2:Other") | |||
| # @pytest.mark.skip("CFNV2:Other") | |||
There was a problem hiding this comment.
Nit: we should delete the comment if it doesn't apply anymore.
Comment on lines
+220
to
+224
| parameter_value = value.get("ParameterValue", "") | ||
| # V2: we model parameters as classes so try to access the method that returns the resolved value | ||
| if resolve := getattr(parameter_value, "resolve", None): | ||
| parameter_value = resolve() | ||
| formatted_stack_parameters[key] = parameter_value.split(",") |
There was a problem hiding this comment.
comment: Thanks for adapting the execute_macro function but I believe that we should have a new one with proper typing and bindings for the v2 engine. Of course that should be handled in another PR not this one.
Comment on lines
+238
to
+243
| if dynamic_ref := extract_dynamic_reference(result): | ||
| return perform_dynamic_reference_lookup( | ||
| reference=dynamic_ref, | ||
| account_id=account_id, | ||
| region_name=region_name, | ||
| ) |
|
Closing in favour of #12965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The V2 engine does not currently support resolving dynamic parameter values, e.g.
Changes