SES: implement SetIdentityHeadersInNotificationsEnabled API #12823
Conversation
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
alexrashed
added
the
semver: patch
…NotificationsEnabled
There was a problem hiding this comment.
Looks pretty good already @YelynnOh. I have last few nits and we can merge this
|
@YelynnOh There are some linting failures that are preventing the pipeline from completing. They should be simple to resolve by running |
|
@viren-nadkarni I ran |
|
@viren-nadkarni Thankyou for adjusting the arguments. I have added |
viren-nadkarni
added
semver: minor
Motivation
close #12516
The issue was caused because the
SetIdentityHeadersInNotificationsEnabledAPI was not implemented in LocalStack’s SES provider, resulting in failures when this API was called.This PR adds the
SetIdentityHeadersInNotificationsEnabledAPI.The reference for this api is written below, if needed.
https://docs.aws.amazon.com/ses/latest/APIReference/API_SetIdentityHeadersInNotificationsEnabled.html
Changes
SetIdentityHeadersInNotificationsEnabledhandler inlocalstack-core/localstack/services/ses/provider.py.tests/aws/services/ses/test_ses.pyto verify the new API.test_ses.snapshot.jsonis also added.