Skip to content

LDM Migration #12852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

LDM Migration #12852

merged 1 commit into from
Jul 31, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Jul 10, 2025 •
edited by joe4dev
Loading

⚠️ This PR needs to be merged shortly before the localstack-pro companion PR because it migrates a feature that cannot co-exist in community and pro.

⚠️ Please align with @MEPalma and the release coordinators before merging! See localstack-pro PR (linked privately below) for details.
/cc @alexrashed

Motivation

Carries out the migration of the LDM.

Changes

Removed LDM modules and introduced needed integrations to support the migration.

@MEPalma MEPalma added this to the Playground milestone Jul 10, 2025
@MEPalma MEPalma self-assigned this Jul 10, 2025
@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jul 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 980 tests   - 12   20 246 ✅  - 12   6m 24s ⏱️ -3s
     1 suites ± 0    1 734 💤 ± 0 
     1 files   ± 0        0 ❌ ± 0 

Results for commit f1a6ae9. ± Comparison against base commit 476e7f3.

This pull request removes 12 tests. 
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_base[base]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_base[base_unqualified]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[deplicate_arn]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[duplicate_debug_port]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[duplicate_implicit_arn]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[empty]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[invalid_arn_structure]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[invalid_missing_qualifier_arn]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[null_enforce_timeouts]
tests.unit.lambda_debug_mode.test_config_parsing ‑ test_debug_config_invalid[null_function_config]
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f1a6ae9. ± Comparison against base commit 476e7f3.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 19m 3s ⏱️
4 848 tests 4 367 ✅ 481 💤 0 ❌
4 854 runs  4 367 ✅ 487 💤 0 ❌

Results for commit f1a6ae9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 34s ⏱️ +42s
4 489 tests ±0  4 161 ✅ ±0  328 💤 ±0  0 ❌ ±0 
4 491 runs  ±0  4 161 ✅ ±0  330 💤 ±0  0 ❌ ±0 

Results for commit f1a6ae9. ± Comparison against base commit 476e7f3.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma marked this pull request as ready for review July 14, 2025 12:35
@MEPalma MEPalma force-pushed the MEP-LDM-provisioner branch from 90030a5 to 6bc6c40 Compare July 16, 2025 07:25
Base automatically changed from MEP-LDM-provisioner to main July 17, 2025 11:59
@joe4dev joe4dev modified the milestones: Playground, 4.7 Jul 23, 2025
@localstack localstack deleted a comment from localstack-bot Jul 25, 2025
dfangl
dfangl approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work starting to decouple it. In the future, we might want to get rid of mentions of LDM altogether, and generalize the hooks and patches, but for now I think this is a good compromise!

localstack-core/localstack/services/lambda_/invocation/executor_endpoint.py
Comment on lines +209 to +211
if ldm.IS_LDM_ENABLED:
# The value is set to a default high value to ensure eventual termination.
timeout_seconds = DEFAULT_LAMBDA_DEBUG_MODE_TIMEOUT_SECONDS
timeout_seconds = ldm.DEFAULT_LDM_TIMEOUT_SECONDS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could further decouple this in the future, by making it more generic, and avoid mentioning LDM altogether. I think this is fine for now though!

@alexrashed
Copy link
Member

alexrashed commented Jul 30, 2025 •
edited
Loading

I was trying to rebase this PR but was facing conflicts.
@MEPalma Could you please rebase this PR as well as the companion to make sure this PR really still is ready to be merged?

@coveralls
Copy link

Coverage Status

coverage: 83.267% (+31.9%) from 51.395%
when pulling f1a6ae9 on MEP-LDM-migrate
into 476e7f3 on main.

@localstack localstack deleted a comment from localstack-bot Jul 31, 2025
@alexrashed alexrashed merged commit 5967923 into main Jul 31, 2025
40 of 41 checks passed
@alexrashed alexrashed deleted the MEP-LDM-migrate branch July 31, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.
5 participants
@MEPalma @alexrashed @coveralls @dfangl @joe4dev