Skip to content

APIGW: update CFN related snapshots #12866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025
Merged

APIGW: update CFN related snapshots #12866

merged 5 commits into from
Jul 16, 2025

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jul 15, 2025

Motivation

Follow up from #12826, we took extra care with @ArthurAkh to make sure we would not break upstream pipelines, but the test selection did not trigger on CloudFormation and Scenario tests, making us miss some outdated snapshots (https://github.com/localstack/localstack/runs/46031151305)

This PR regenerated those outdated snapshots

Changes

  • regenerate CFN / Scenario tests related to APIGW
  • update snapshot skip related to DynamoDB

@bentsku bentsku added this to the 4.7 milestone Jul 15, 2025
@bentsku bentsku requested review from ArthurAkh and cloutierMat July 15, 2025 19:41
@bentsku bentsku added aws:cloudformation AWS CloudFormation aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases labels Jul 15, 2025
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks for the quick snapshot update 🙏

I only left a comment regarding some snapshot that could be transformed, but it should be good to do in a follow up. cc: @pinzon @simonrw

@@ -56,7 +57,7 @@
"Architectures": [
"x86_64"
],
"CodeSha256": "+xvKfGS3ENINs/yK7dLJgId2fDM+vv9OP03rJ9mLflU=",
"CodeSha256": "W479VjWcFpBg+yx255glPq1ZLEq5WjlmjJi7CmxLFio=",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (non-blocking): I know this is unrelated to this change, but it might be worth transforming this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, it also troubled me but I realized only after regenerating all of them 🤦‍♂️ I figured this could be tackled as a follow-up. Good catch!

Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this 👍

Copy link

github-actions bot commented Jul 15, 2025

Test Results - Preflight, Unit

21 862 tests  ±0   20 205 ✅ ±0   6m 23s ⏱️ -23s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 1b6c60f. ± Comparison against base commit e38e9c6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 15, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1b6c60f. ± Comparison against base commit e38e9c6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 15, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 25s ⏱️
5 288 tests 4 358 ✅ 930 💤 0 ❌
5 294 runs  4 358 ✅ 936 💤 0 ❌

Results for commit 1b6c60f.

♻️ This comment has been updated with latest results.

Comment on lines -332 to -336
"$.get-stage.createdDate",
"$.get-stage.lastUpdatedDate",
"$.get-stage.methodSettings",
"$.get-stage.tags",
"$..endpointConfiguration.ipAddressType",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link

github-actions bot commented Jul 15, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 5s ⏱️ -14s
4 929 tests ±0  4 152 ✅ +5  777 💤 ±0  0 ❌  - 5 
4 931 runs  ±0  4 152 ✅ +5  779 💤 ±0  0 ❌  - 5 

Results for commit 1b6c60f. ± Comparison against base commit e38e9c6e.

♻️ This comment has been updated with latest results.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for jumping on this! 💯 🦸🏽

@alexrashed alexrashed merged commit 8607af6 into master Jul 16, 2025
39 checks passed
@alexrashed alexrashed deleted the update-apigw-snapshots branch July 16, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:apigateway Amazon API Gateway aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants