-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
APIGW: update CFN related snapshots #12866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -56,7 +57,7 @@ | |||
"Architectures": [ | |||
"x86_64" | |||
], | |||
"CodeSha256": "+xvKfGS3ENINs/yK7dLJgId2fDM+vv9OP03rJ9mLflU=", | |||
"CodeSha256": "W479VjWcFpBg+yx255glPq1ZLEq5WjlmjJi7CmxLFio=", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (non-blocking): I know this is unrelated to this change, but it might be worth transforming this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, it also troubled me but I realized only after regenerating all of them 🤦♂️ I figured this could be tackled as a follow-up. Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for handling this 👍
Test Results - Preflight, Unit21 862 tests ±0 20 205 ✅ ±0 6m 23s ⏱️ -23s Results for commit 1b6c60f. ± Comparison against base commit e38e9c6e. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Acceptance7 tests ±0 5 ✅ ±0 3m 9s ⏱️ +3s Results for commit 1b6c60f. ± Comparison against base commit e38e9c6e. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 25s ⏱️ Results for commit 1b6c60f. ♻️ This comment has been updated with latest results. |
"$.get-stage.createdDate", | ||
"$.get-stage.lastUpdatedDate", | ||
"$.get-stage.methodSettings", | ||
"$.get-stage.tags", | ||
"$..endpointConfiguration.ipAddressType", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 43m 5s ⏱️ -14s Results for commit 1b6c60f. ± Comparison against base commit e38e9c6e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for jumping on this! 💯 🦸🏽
Motivation
Follow up from #12826, we took extra care with @ArthurAkh to make sure we would not break upstream pipelines, but the test selection did not trigger on CloudFormation and Scenario tests, making us miss some outdated snapshots (https://github.com/localstack/localstack/runs/46031151305)
This PR regenerated those outdated snapshots
Changes