Skip to content

Pin aws cli version instead of having a lower bound #12867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Pin aws cli version instead of having a lower bound #12867

merged 2 commits into from
Jul 16, 2025

Conversation

silv-io
Copy link
Member

@silv-io silv-io commented Jul 16, 2025 •
edited by alexrashed
Loading

Motivation

With #12857 we increased the AWS cli version lower boundary to avoid backtracking that takes too long.
However, we could instead pin the version based on a successful resolution.
To resolve we can use uv to have it be as fast as possible

Changes

  • add a step to resolve a compatible awscli version that works with the pinned botocore version
  • pin that version in the pyproject.toml and also pin that version in the requirements lock files

Testing

  • Executed the update action based on this PR workflow code here

TODO

What's left to do:

@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jul 16, 2025
@silv-io silv-io force-pushed the pin-awscli-version branch 3 times, most recently from f769121 to c6d70e4 Compare July 16, 2025 14:52
@silv-io silv-io force-pushed the pin-awscli-version branch from c6d70e4 to 8196ff6 Compare July 16, 2025 14:57
@silv-io silv-io mentioned this pull request Jul 16, 2025
Closed
@silv-io silv-io marked this pull request as ready for review July 16, 2025 15:04
@silv-io silv-io added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Jul 16, 2025
alexrashed
alexrashed approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for jumping on this! 💯
And a nice first step towards using uv 😛

@silv-io silv-io merged commit 7720cc4 into main Jul 16, 2025
5 checks passed
@silv-io silv-io deleted the pin-awscli-version branch July 16, 2025 15:22
@alexrashed alexrashed mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il is a code owner

Assignees
No one assigned
Labels
review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silv-io @alexrashed