APIGW: support DeploymentCanarySettings for AWS::ApiGateway::Deployment
#12899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:apigateway
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 22m 27s ⏱️ Results for commit d76bae7. |
bentsku
requested review from
dominikschubert,
pinzon,
simonrw and
cloutierMat
as code owners
simonrw
approved these changes
Jul 24, 2025
Comment on lines
+129
to
+131
| if model.get("DeploymentCanarySettings"): | ||
| params["canarySettings"] = model["DeploymentCanarySettings"] | ||
|
|
There was a problem hiding this comment.
Gotta love these short code change PRs! 155 lines added, of which 3 are the implementation (2%)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of some testing (for this sample, I encountered an issue with LocalStack ignoring some configuration.
It did not handle the
DeploymentCanarySettingsproperty forAWS::ApiGateway::DeploymentChanges
DeploymentCanarySettingsproperty and templateDeploymentCanarySettingsin the resource provider