feat: add the pro activation to the tracked environment variables #12902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
All contributors have signed the CLA ✍️ ✅ |
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 59s ⏱️ Results for commit eff12c7. |
kittylon
added
the
semver: minor
|
I have read the CLA Document and I hereby sign the CLA |
localstack-bot
added a commit
that referenced
this pull request
Jul 24, 2025
kittylon
requested review from
ackdav,
vittoriopolverino,
valentinarmo and
AlessandroLollo
valentinarmo
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tracking the
ACTIVATE_PROwill enable us to identify sessions that use the pro image with an invalid token and fall back to the community image.Context:
Some users set an invalid token using the pro image and set the
ACTIVATE_PRO=0variable.Without this, it appears that someone started a session with an invalid token using the pro image, which is misleading, as they would fall back to the community in this situation.
What changes does this PR make?
Adds
ACTIVATE_PROto the list of tracked environment variables that are sent to the analytics backend, so that it's ingested into TinyBird.