KMS: return NotImplementedError for rotation of imported keys
#12932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sannya-singal
added
aws:kms
LocalStack Community integration with Pro 2 files 2 suites 4m 33s ⏱️ Results for commit 40a5ce0. ♻️ This comment has been updated with latest results. |
|
The pipeline failed: https://github.com/localstack/localstack/actions/runs/16620811305/job/47024507676?pr=12932 because |
sannya-singal
added
the
review: merge when ready
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 17m 48s ⏱️ Results for commit 40a5ce0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After the launch of this feature, AWS introduced support for on demand rotation of imported keys i.e. keys with
Originset toEXTERNAL.At the moment, LocalStack does not support this feature and we return a
400error withUnsupportedOperationExceptioneven though the request itself is valid.Changes
Raise appropriate error response with error code
501when rotation of keys is done with imported keys.Please note, this PR does not aim to fix existing tests and other logic in the code which revolves around assuming that external keys are unsupported, this should be tackled in a separate PR.