CFNV2: defer deletions for correcting deploy order #12936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 36s ⏱️ Results for commit 87d33ca. ♻️ This comment has been updated with latest results. |
|
@simonrw we should convert this PR to a draft for now |
simonrw
force-pushed
the
cfn/v2/deletion-order
branch
from
6666cde to
bb135e7
Compare
simonrw
force-pushed
the
cfn/v2/deletion-order
branch
from
bb135e7 to
21bf39b
Compare
pinzon
approved these changes
Aug 1, 2025
| # perform all deferred actions such as deletions. These must happen in reverse from their | ||
| # defined order so that resource dependencies are honoured | ||
| # TODO: errors will stop all rollbacks; get parity on this behaviour | ||
| for action in self._deferred_actions[::-1]: |
There was a problem hiding this comment.
Suggestion: Consider setting the stack status to UPDATE_COMPLETE_CLEANUP_IN_PROGRESS when the deferred actions are being executed.
There was a problem hiding this comment.
That's a great idea, thanks @pinzon !
simonrw
force-pushed
the
cfn/v2/deletion-order
branch
from
d87da8e to
87d33ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CloudFormation ensures that resources that require replacement are deleted once the new stack state is fully deployed. It also removes resources in reverse order of their dependency chain.
Changes