SQS: fix DelaySeconds behavior for FIFO queues on message level #12941
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
gregfurman
added
aws:sqs
|
Not letting me add labels myself, if someone with access can please add semver:patch and aws:sqs please |
baermat
added
semver: patch
There was a problem hiding this comment.
LGTM! Thanks for neat contribution 🚀 Nothing blocking this imo. Just some suggestions (that I'm not married to).
Also, to unblock the CI, can you agree to the CLA license? See bot comment #12941 (comment)
|
I have read the CLA Document and I hereby sign the CLA |
|
Also, it seems there are merge conflicts 🤔 Once they're resolved I'll merge 👍 |
Resolved conflicts -- also ran the linter+formatter which I forgot previously. Thanks for the review :) |
Motivation
As reported in #12881 when a FIFO SQS queue has a default DelaySeconds value (e.g. 60 seconds), LocalStack honors an explicit SendMessage call with DelaySeconds=0 and makes the message immediately visible.
This behavior differs from AWS SQS, where a DelaySeconds=0 parameter is ignored and the queue’s default delay is applied instead.
To ensure behavior parity with AWS SQS—and prevent surprises when migrating from AWS to LocalStack—LocalStack should ignore explicit DelaySeconds=0 for FIFO queues and respect the queue’s default settings.
Changes