Skip to content

mitigate issues with pip-tools 7.5.0 with dependency limit #12947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

mitigate issues with pip-tools 7.5.0 with dependency limit #12947

merged 1 commit into from
Aug 4, 2025

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Aug 4, 2025 •
edited
Loading

Motivation

A few days ago, pip-tools==7.5.0 has been released.
With our weekly ASF update action, we are now facing an issue which was introduced by this version: jazzband/pip-tools#2215
Immediately on the first call of pip-compile in this workflow the execution fails with the following trace:

 Traceback (most recent call last):
  File "/home/runner/work/localstack/localstack/.venv/bin/pip-compile", line 7, in <module>
    sys.exit(cli())
             ^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/click/core.py", line 1442, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/click/core.py", line 1363, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/click/core.py", line 1226, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/click/core.py", line 794, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/click/decorators.py", line 34, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/piptools/scripts/compile.py", line 371, in cli
    metadata = build_project_metadata(
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/piptools/build.py", line 159, in build_project_metadata
    project_metadata = maybe_statically_parse_project_metadata(src_file)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/localstack/localstack/.venv/lib/python3.11/site-packages/piptools/build.py", line 106, in maybe_statically_parse_project_metadata
    requirement.url = src_file.parent.as_uri()
                      ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.13/x64/lib/python3.11/pathlib.py", line 566, in as_uri
    raise ValueError("relative path can't be expressed as a file URI")
ValueError: relative path can't be expressed as a file URI
Error: Process completed with exit code 1.

This PR mitigates this issue by avoiding this release / introducing dependency limits when installing pip-tools.
This PR should be reverted once the issue has been resolved by the pip-tools team.

Changes

Testing

@alexrashed alexrashed added this to the 4.8 milestone Aug 4, 2025
@alexrashed alexrashed requested review from silv-io and k-a-il August 4, 2025 08:41
@alexrashed alexrashed added area: ci Running LocalStack in CI environments area: asf semver: patch Non-breaking changes which can be included in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted labels Aug 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 48s ⏱️
  515 tests 465 ✅  50 💤 0 ❌
1 030 runs  930 ✅ 100 💤 0 ❌

Results for commit 7f8f846.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

Test Results - Preflight, Unit

21 984 tests  ±0   20 250 ✅ ±0   6m 21s ⏱️ -3s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 7f8f846. ± Comparison against base commit 8a3264e.

@alexrashed alexrashed mentioned this pull request Aug 4, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 18s ⏱️ +11s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7f8f846. ± Comparison against base commit 8a3264e.

dfangl
dfangl approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to pin until this gets fixed!

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 20m 47s ⏱️
4 945 tests 4 383 ✅ 562 💤 0 ❌
4 951 runs  4 383 ✅ 568 💤 0 ❌

Results for commit 7f8f846.

@alexrashed alexrashed merged commit c5c7aaa into main Aug 4, 2025
61 checks passed
@alexrashed alexrashed deleted the fix-dependency-lock-update branch August 4, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

@silv-io silv-io

Labels
area: asf area: ci Running LocalStack in CI environments review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @dfangl @silv-io