LocalStack SDK for integration tests #12991
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giograno
added
the
semver: patch
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 25s ⏱️ Results for commit 30cee15. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 20m 36s ⏱️ Results for commit 30cee15. |
giograno
requested review from
viren-nadkarni,
dominikschubert,
alexrashed,
silv-io,
k-a-il,
bentsku and
sannya-singal
as code owners
giograno
removed request for
dominikschubert,
alexrashed,
silv-io,
sannya-singal and
k-a-il
alexrashed
requested changes
Aug 12, 2025
| @@ -116,6 +116,7 @@ test = [ | |||
| "aws-cdk-lib>=2.88.0", | |||
| "websocket-client>=1.7.0", | |||
| "localstack-snapshot>=0.1.1", | |||
| "localstack-sdk-python" | |||
There was a problem hiding this comment.
issue: This effectively implements a circular dependency:
- The SDK is directly generated from the OpenAPI specs.
- The OpenAPI specs are released with every release of LocalStack Pro.
- The SDK is defined as a dependency of LocalStack Pro's test dependencies here.
In my opinion, this could make it very much more tedious to implement changes when changing the API endpoint or adding new ones.
But what exactly is the motivation behind using the SDK here directly?
- Is it to save some lines of code? Maybe we should then restructure the code or the API to make sure the API is very easily usable.
- Or is it to verify that the SDK works? I think that should be verified directly in the repo of the SDK. If you want to do regular integration tests, you could run a scheduled integration test pipeline there, ensuring that the latest SDK still integrates well with latest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #12972 @viren-nadkarni suggested using the LocalStack SDK for our own integration tests.
Changes
This PR:
localstack-sdk-pythonto our test dependencies;