MNT: Refactor default violin KDE estimator #30387
Open
+38
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the default KDE estimator from a private definition in
violinplot()
intoviolin_stats()
. This makes it easier to test and debug violin_stats() as we don't have to explicitly provide a KDE method.It also becomes logically simpler, because
violinplot()
is now onlyviolin_stats()
+violin()
.This will make it easier to resolve #30355.