Skip to content

Conversation

wzimrin
Copy link
Contributor

@wzimrin wzimrin commented Jul 25, 2025

Closes https://github.com/metabase/metabase/issues/[issue_number]

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

  • Tests have been added/updated to cover changes in this PR

["AS"]
(sql.qp/format-honeysql driver {:raw sql})]
query (str/join " " (map first pieces))
params (reduce into [] (map rest pieces))]
Copy link
Contributor

@metamben metamben Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(into [query] (mapcat rest) pieces), but I cannot imagine how any of the above things could generate parameters. (I should have made this comment on the next line, sorry.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants