fix: adding trialing slash detection logic back in urlToWSEndpoint #36357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I think it would be great to add a test for that, would it be possible to add one - somewhere around here? https://github.com/microsoft/playwright/blob/main/tests/library/chromium/connect-over-cdp.spec.ts |
Test results for "tests 1"6 flaky39442 passed, 823 skipped Merge workflow run. |
mxschmitt
approved these changes
Jun 20, 2025
This was referenced Jun 20, 2025
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply brings the previous behavior back before: eb5e3b3
This commit will break if the url has custom sections:
For chrome cdp, it is possible to get
webSocketDebuggerUrlby some verbose path: