Skip to content

Conversation

@KapitanOczywisty
Copy link
Contributor

This is fix for broken syntax:

  • functions w/o body in interfaces upstream
  • attributes with leading whitespaces upstream

This is quick fix to get insiders running before PRs will be merged upstream.

Assign: @roblourens

Fixes #113185

@roblourens
Copy link
Member

roblourens commented Jan 12, 2021

Thanks @KapitanOczywisty, looks like your upstream PRs got merged so I can do a normal update, assuming master upstream is stable

@roblourens roblourens closed this Jan 12, 2021
@KapitanOczywisty
Copy link
Contributor Author

assuming master upstream is stable

@roblourens They are using version from September in atom. It's as stable as I could check, but I'm keeping tests in good shape so should be fine. Also I'm fixing issues right away, but then we have to wait almost 2 weeks to merge and I bet they are not checking If update is working anyway...

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP (built-in): Incorrect syntax highlighting with interface

3 participants