chore: create include.gypi for Windows build again #224445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Aug 1, 2024
There was a problem hiding this comment.
LGTM, pending verification build
https://monacotools.visualstudio.com/Monaco/_build/results?buildId=286148&view=results
rzhao271
force-pushed
the
rzhao271/ratty-sparrow
branch
from
c95c055 to
ad2a343
Compare
|
I started a newer verification build at https://monacotools.visualstudio.com/Monaco/_build/results?buildId=286190&view=results but it still has the terminal smoke test failure. Based on the pipeline runs, I believe the failure is unrelated to this change. |
Co-authored-by: Robo <[email protected]>
amunger
approved these changes
Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add this PR to temporarily resolve the kerberos BinSkim issue on our end.
Once kerberos releases a new package, we will consume it and remove this patch to detect future upstream BinSkim issues.