Skip to content

change ChatPromptFiles to not be a previewFeature #256568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jul 17, 2025

No description provided.

@aeschli aeschli enabled auto-merge (squash) July 17, 2025 20:08
@aeschli aeschli self-assigned this Jul 17, 2025
@aeschli aeschli requested a review from joshspicer July 17, 2025 20:08
@vs-code-engineering vs-code-engineering bot added this to the July 2025 milestone Jul 17, 2025
@aeschli
Copy link
Contributor Author

aeschli commented Jul 17, 2025

@joshspicer Is this the correct change?

@@ -398,7 +398,7 @@ configurationRegistry.registerConfiguration({
minimumVersion: '1.99',
description: nls.localize('chat.promptFiles.policy', "Enables reusable prompt and instruction files in Chat sessions."),
defaultValue: false,
tags: [PolicyTag.Account, PolicyTag.Preview]
tags: [PolicyTag.Account]
Copy link
Member

@joshspicer joshspicer Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can entirely remove tags and defaultValue. Those parameters are only needed when this setting is controllable by your signed in account

ref #256571 to update the inline documentation

@aeschli
Copy link
Contributor Author

aeschli commented Jul 21, 2025

@joshspicer Is it ok now?

@aeschli aeschli merged commit 61ac05d into main Jul 21, 2025
18 checks passed
@aeschli aeschli deleted the aeschli/consistent-deer branch July 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants