Adds support for proper localhost loopback on RFC 6761 #256617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🔍 Added TLD matching for localhost variations - ✅ Updated tests to cover new localhost cases
lramos15
previously approved these changes
Jul 18, 2025
rzhao271
previously approved these changes
Jul 18, 2025
rzhao271
approved these changes
Jul 21, 2025
Tyriar
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256611
The solution follows RFC 6761 standards where .localhost is a special-use top-level domain reserved for loopback purposes. The regex pattern ^(.+.)?localhost(:\d+)?$ matches:
localhost (the base domain)
*.localhost (any subdomain of localhost)
Optional port numbers (e.g., :3000, :8080)
Case-insensitive matching
Now when you encounter links ending with dev.localhost or any other *.localhost subdomain, VS Code will automatically trust them and won't prompt you to configure trusted domains or ask if you want to open the external website. This provides the same seamless experience as localhost itself, which aligns with the RFC 6761 specification that treats the entire .localhost TLD as reserved for local loopback testing.