Make chat elicitation request part accessible #257491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: meganrogge <[email protected]>
Co-authored-by: meganrogge <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
meganrogge
July 23, 2025 17:17
|
@copilot we should also use an aria alert to indicate the contents of the elicitation request to screen reader users when it comes in. We should also add this content to the aria label of the chat response list item like we do for other points of interest, such as code blocks. |
meganrogge
reviewed
Jul 23, 2025
src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: meganrogge <[email protected]>
I've implemented both requested accessibility improvements:
The changes integrate cleanly with existing accessibility infrastructure and provide immediate notification plus persistent labeling for screen reader users. Commit: 8c8e475 |
Copilot finished work on behalf of
meganrogge
July 23, 2025 18:41
Copilot finished work on behalf of
meganrogge
July 23, 2025 18:44
meganrogge
changed the title
meganrogge
approved these changes
Jul 23, 2025
|
CC @connor4312 |
meganrogge
approved these changes
Jul 23, 2025
rzhao271
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat elicitations, used by mcp and task/terminal tools, were inaccessible before. This fixes it: