Skip to content

inline code actions fix #257909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

inline code actions fix #257909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ca06c7
inline code actions fix
justschen Jul 25, 2025
c5e5efa
Merge branch 'main' into justin/nuzleaf
justschen Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/vs/editor/contrib/codeAction/browser/codeActionModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,12 @@ export class CodeActionModel extends Disposable {
return emptyCodeActionSet;
}

// Search for quickfixes in the curret code action set.
const foundQuickfix = codeActionSet.validActions?.some(action => action.action.kind ? CodeActionKind.QuickFix.contains(new HierarchicalKind(action.action.kind)) : false);
// Search for non-AI quickfixes in the current code action set - if AI code actions are the only thing found, continue searching for diagnostics in line.
const foundQuickfix = codeActionSet.validActions?.some(action => {
return action.action.kind &&
CodeActionKind.QuickFix.contains(new HierarchicalKind(action.action.kind)) &&
!action.action.isAI;
});
const allMarkers = this._markerService.read({ resource: model.uri });
if (foundQuickfix) {
for (const action of codeActionSet.validActions) {
Expand Down
Loading