Skip to content

Added Xonsh shell type #284044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 9 commits into from
Jan 5, 2026
Merged

Added Xonsh shell type #284044

Tyriar merged 9 commits into from
Jan 5, 2026

Conversation

@anki-code
Copy link
Contributor

@anki-code anki-code commented Dec 17, 2025 •
edited
Loading

Address #239631 - adding xonsh shell as general shell type.

Copilot AI review requested due to automatic review settings December 17, 2025 12:10
Copilot AI reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the Xonsh shell by introducing a new shell type Xonsh = 'xonsh' to the GeneralShellType enum. Xonsh is a Python-powered shell that combines Python syntax with shell commands, and support for it already exists in other parts of the codebase (e.g., shell environment detection in shellEnv.ts).

Key Changes:

  • Adds Xonsh = 'xonsh' to the GeneralShellType enum in the terminal platform definitions

@anki-code
Copy link
Contributor Author

anki-code commented Dec 17, 2025

@microsoft-github-policy-service agree

@anki-code anki-code marked this pull request as ready for review December 17, 2025 12:28
@vs-code-engineering
Copy link

vs-code-engineering bot commented Dec 17, 2025

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@Tyriar

Matched files:

  • src/vs/platform/terminal/node/terminalProcess.ts
  • src/vs/platform/terminal/node/windowsShellHelper.ts

Tyriar
Tyriar requested changes Dec 21, 2025
View reviewed changes
@Tyriar Tyriar added this to the December / January 2026 milestone Dec 21, 2025
@anki-code anki-code requested a review from Tyriar December 21, 2025 13:13
Tyriar
Tyriar previously approved these changes Dec 21, 2025
View reviewed changes
@Tyriar Tyriar enabled auto-merge December 21, 2025 13:29
alexr00
alexr00 previously approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment change in vscode.d.ts looks good. @Tyriar CI is failing though.

@anki-code anki-code requested a review from Tyriar January 5, 2026 13:04
@anthonykim1
Copy link
Contributor

anthonykim1 commented Jan 5, 2026

Thank you for the PR @anki-code
Could you run format document on src/vs/platform/terminal/node/terminalProcess.ts and src/vs/platform/terminal/node/windowsShellHelper.ts?

@Tyriar Tyriar dismissed stale reviews from alexr00 and themself via 550f052 January 5, 2026 18:47
@Tyriar Tyriar merged commit 9564c70 into microsoft:main Jan 5, 2026
17 checks passed
@anki-code anki-code mentioned this pull request Jan 6, 2026
Closed
@anki-code
Copy link
Contributor Author

anki-code commented Jan 9, 2026

Please add xonsh shell support into release notes if possible. Thanks!

@anki-code anki-code mentioned this pull request Jan 9, 2026
Open
@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2026

@anki-code we often do minor changes like this and we typically don't mention. If we added support to pull history or something for run recent command, that would be something worth mentioning.

@anki-code anki-code mentioned this pull request Jan 9, 2026
Open
@wajdiJomaa wajdiJomaa mentioned this pull request Jan 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Tyriar Tyriar Tyriar approved these changes

@rzhao271 rzhao271 rzhao271 approved these changes

@mjbvz mjbvz mjbvz approved these changes

@alexr00 alexr00 alexr00 left review comments

@jrieken jrieken Awaiting requested review from jrieken jrieken is a code owner

Assignees

@anthonykim1 anthonykim1

Labels

None yet

Projects

None yet

Milestone

December 2025

Development

Successfully merging this pull request may close these issues.

6 participants

@anki-code @anthonykim1 @Tyriar @rzhao271 @mjbvz @alexr00