bug fix: enhance conda environment management with sourcing status and updated shell activation support #693
+607
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d updated shell activation support
eleanorjboyd
force-pushed
the
everything-bagel
branch
from
07ab05c to
0bd3547
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances conda environment management by adding sourcing status detection and improving shell activation support. The changes introduce a new system to determine whether conda is already active in the current shell and provide better shell-specific activation commands.
- Adds
CondaSourcingStatusclass to track conda initialization state - Refactors shell activation command generation to use sourcing information
- Introduces detection of global and shell-specific conda activation scripts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/managers/conda/main.ts | Adds sourcing status construction and assignment to environment manager |
| src/managers/conda/condaUtils.ts | Refactors shell activation logic to use sourcing status and removes duplicate code |
| src/managers/conda/condaSourcingUtils.ts | New utility for detecting conda sourcing status and activation scripts |
| src/managers/conda/condaEnvManager.ts | Adds sourcingInformation property to store sourcing status |
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.