Store the checksum in PostPolicyHandler so that we can return it on G… #20364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etObject requests
marktheunissen
commented
Sep 2, 2024
| writeErrorResponseHeadersOnly(w, toAPIError(ctx, err)) | ||
| return | ||
| } | ||
| opts.WantChecksum = checksum |
Contributor
Author
There was a problem hiding this comment.
@klauspost I believe we only need this single line from the snippet you provided on the issue, since we already AddChecksumNoTrailer here: https://github.com/minio/minio/blob/master/cmd/bucket-handlers.go#L1147-L1152
Correct me if I'm wrong, but the mint test in minio/minio-go#1996 passes with this single line change.
klauspost
approved these changes
Sep 2, 2024
Contributor
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
Awesome! The less code the better!
harshavardhana
approved these changes
Sep 2, 2024
harshavardhana
pushed a commit
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etObject requests
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Fixes: #20343
How to test this PR?
Mint tests: minio/minio-go#1996
Types of changes
Checklist:
commit-idorPR #here)