rename ResourceReference to ResourceTemplateReference #193
+42
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the ResourceReference class to ResourceTemplateReference to better reflect its purpose as a reference to resource or resource template definitions. The change improves code clarity by making the class name more descriptive of its actual functionality.
- Renamed
ResourceReferencedata class toResourceTemplateReferencein the main types file - Updated the polymorphic serializer to use the new class name for deserialization
- Updated the Kotlin SDK API documentation to reflect the class name change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/types.kt | Renamed the data class from ResourceReference to ResourceTemplateReference |
| src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/types.util.kt | Updated polymorphic serializer to reference the renamed class |
| api/kotlin-sdk.api | Updated API documentation to remove old class definition and add new class definition |
devcrocod
force-pushed
the
rename-resource-reference
branch
from
1514449 to
fb7deae
Compare
devcrocod
force-pushed
the
rename-resource-reference
branch
from
fb7deae to
8463e0e
Compare
sdubov
previously approved these changes
Aug 6, 2025
|
Thank you for your contribution! Looks good for me. Just need to resolve the merge conflicts before merging. |
devcrocod
force-pushed
the
rename-resource-reference
branch
from
8463e0e to
c93b835
Compare
sdubov
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed ResourceReference to ResourceTemplateReference in source code and the kotlin sdk api documentation file
Motivation and Context
#186
How Has This Been Tested?
gradle build successful
Breaking Changes
Yes, they need to change the name in function calls as well
Types of changes
Checklist
Additional context
none