Skip to content

Fix incorrect deserializer mapping notifications #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

devcrocod
Copy link
Contributor

#173

How Has This Been Tested?

locally

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes incorrect method mappings in the server notification deserializer by updating the method values used for tool and prompt list change notifications to their correct notification-specific variants.

  • Updates tool list change mapping from ToolsList to NotificationsToolsListChanged
  • Updates prompt list change mapping from PromptsList to NotificationsPromptsListChanged

@devcrocod devcrocod force-pushed the devcrocod/fix-173 branch 2 times, most recently from 36b452c to 37a785f Compare August 4, 2025 16:42
Copy link
Contributor

@sdubov sdubov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@devcrocod devcrocod enabled auto-merge (squash) August 5, 2025 09:44
@devcrocod devcrocod merged commit b0f0759 into main Aug 5, 2025
4 checks passed
@devcrocod devcrocod deleted the devcrocod/fix-173 branch August 5, 2025 10:51
skarpovdev pushed a commit to skarpovdev/kotlin-sdk that referenced this pull request Aug 5, 2025
skarpovdev pushed a commit to skarpovdev/kotlin-sdk that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants