Skip to content

use SSEClientExcpetion instead of ClientRequestException #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use SSEClientExcpetion instead of ClientRequestException #207

wants to merge 1 commit into from
+3 −2

Conversation

shiqicao
Copy link
Contributor

@shiqicao shiqicao commented Aug 2, 2025

Client.sseSession doesn't throw ClientRequestException, it throws SSEClientException

Motivation and Context

Without this fix, StreamableHTTPTransport crashes for stateless request

How Has This Been Tested?

Manually tested

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@shiqicao shiqicao changed the title use SSEClientExcpetion instead of ClientRequestClient use SSEClientExcpetion instead of ClientRequestException Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shiqicao