Skip to content

Add missing id fields to next page requests #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikekistler
Copy link
Contributor

This PR fixes a minor issue with the pagination request examples -- they were missing an id field, which is a required field in JSON RPC requests.

Motivation and Context

Fix the examples to be valid requests.

How Has This Been Tested?

Doc only change.

Breaking Changes

Not breaking.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

I have only made this fix in the 2025-06-18 and draft spec directories. I think the problem also exists in earlier versions -- I can push fixes for those as well if that's desired.

Copy link
Contributor

@hesreallyhim hesreallyhim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems pretty straightforward to me ✅

(Unofficial review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants