Skip to content

Remove pyca/cryptography backend's dependency on python-ecdsa #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 27, 2018
Merged

Remove pyca/cryptography backend's dependency on python-ecdsa #117

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b6fa7a
add ability to remove base crypto backend for tests
mattsb42-aws Dec 25, 2018
28dcc70
update Travis CI to run cryptography-only
mattsb42-aws Dec 25, 2018
9222673
isolate ecdsa key class imports to allow for missing library
mattsb42-aws Dec 25, 2018
04ef8b5
isolate asn1/der signature transformation to simplify testing
mattsb42-aws Dec 25, 2018
cea6ae8
add tests to verify der/asn1 conversions
mattsb42-aws Dec 25, 2018
e786a0e
remove dependency of pyca/cryptography backend on python-ecdsa
mattsb42-aws Dec 25, 2018
93a3c0a
JOSE ECDSA signature encoding is raw encoding, not ASN1
mattsb42-aws Dec 25, 2018
e2189cb
math.ceil returns a float in Python 2
mattsb42-aws Dec 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests to verify der/asn1 conversions
  • Loading branch information
@mattsb42-aws
mattsb42-aws committed Dec 25, 2018
commit cea6ae82f31c0fea863f2bc28a17ba31ef3e61cb
26 changes: 26 additions & 0 deletions tests/algorithms/test_EC.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,18 @@
-----END EC PRIVATE KEY-----
"""

# ES256 signatures generated to test conversion logic
DER_SIGNATURE = (
b"0F\x02!\x00\x89yG\x81W\x01\x11\x9b0\x08\xa4\xd0\xe3g([\x07\xb5\x01\xb3"
b"\x9d\xdf \xd1\xbc\xedK\x01\x87:}\xf2\x02!\x00\xb2shTA\x00\x1a\x13~\xba"
b"J\xdb\xeem\x12\x1e\xfeMO\x04\xb2[\x86A\xbd\xc6hu\x953X\x1e"
)
ASN1_SIGNATURE = (
b"\x89yG\x81W\x01\x11\x9b0\x08\xa4\xd0\xe3g([\x07\xb5\x01\xb3\x9d\xdf "
b"\xd1\xbc\xedK\x01\x87:}\xf2\xb2shTA\x00\x1a\x13~\xbaJ\xdb\xeem\x12\x1e"
b"\xfeMO\x04\xb2[\x86A\xbd\xc6hu\x953X\x1e"
)


def _backend_exception_types():
"""Build the backend exception types based on available backends."""
Expand All @@ -51,6 +63,20 @@ def test_key_from_ecdsa():
assert not ECKey(key, ALGORITHMS.ES256).is_public()


@pytest.mark.cryptography
@pytest.mark.skipif(CryptographyECKey is None, reason="pyca/cryptography backend not available")
def test_cryptograhy_der_to_asn1():
key = CryptographyECKey(private_key, ALGORITHMS.ES256)
assert key._der_to_asn1(DER_SIGNATURE) == ASN1_SIGNATURE


@pytest.mark.cryptography
@pytest.mark.skipif(CryptographyECKey is None, reason="pyca/cryptography backend not available")
def test_cryptograhy_asn1_to_der():
key = CryptographyECKey(private_key, ALGORITHMS.ES256)
assert key._asn1_to_der(ASN1_SIGNATURE) == DER_SIGNATURE


class TestECAlgorithm:

def test_key_from_pem(self):
Expand Down