Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the vim-patch See https://neovim.io/doc/user/dev_vimpatch.html label Sep 14, 2025
@github-actions github-actions bot force-pushed the marvim/ci-version-update branch 3 times, most recently from eae0874 to 3108532 Compare September 17, 2025 03:17
@janlazo
Copy link
Contributor

janlazo commented Sep 17, 2025

vim-patch:8.1.1989: the evalfunc.c file is still too big

vim-patch:8.2.0379: gcc warns for ambiguous else
vim-patch:8.2.0510: Coverity complains about using uninitialized variable
vim-patch:8.2.0566: Vim9: variable can be used uninitialized
vim-patch:8.2.1908: Lua is initialized even when not used
vim-patch:8.2.2313: Vim9: using uninitialized field when parsing range
vim-patch:8.2.2374: accessing uninitialized memory in test_undo
vim-patch:8.2.2509: tests fail on s390 build
vim-patch:8.2.2572: Vim9: crash when getting the types for a legacy function
vim-patch:8.2.3134: crash when using typename() on a function reference
vim-patch:8.2.3527: gcc complains about uninitialized variable
vim-patch:8.2.3653: terminal ANSI colors may be wrong
vim-patch:8.2.3755: Coverity warns for using a buffer in another scope
vim-patch:8.2.3770: new compiler warnings from clang-12 and clang-13
vim-patch:8.2.3875: gcc complains about buffer overrun
vim-patch:8.2.3893: Vim9: many local variables are initialized with an instruction
vim-patch:8.2.4017: gcc warns for misleading indent in Athena menu code
vim-patch:8.2.4023: using uninitialized variable
vim-patch:8.2.4126: crash on exit when built with dynamic Tcl
vim-patch:8.2.4468: Coverity warns for uninitialized struct member
vim-patch:8.2.4471: Coverity warns for uninitialized variable
vim-patch:8.2.4661: Coverity warning for using uninitialized variable
vim-patch:8.2.4779: lsan suppression is too version specific
vim-patch:8.2.4995: still a compiler warning for possibly uninitialized variable
vim-patch:8.2.5005: compiler warning for uninitialized variable
vim-patch:8.2.5068: gcc 12.1 warning when building tee
vim-patch:8.2.5069: various warnings from clang on MS-Windows
vim-patch:8.2.5073: clang on MS-Windows produces warnings
vim-patch:8.2.5075: clang gives an out of bounds warning
vim-patch:8.2.5085: gcc gives warning for signed/unsigned difference
vim-patch:8.2.5087: cannot build with clang on MS-Windows

vim-patch:9.0.0395: clang warnings for function prototypes
vim-patch:9.0.0860: MS-Windows: windres fails with clang 15.0.4
vim-patch:9.0.1088: clang warns for unused variable
vim-patch:9.0.1517: MacOS: configure removes -O2 from $CFLAGS
vim-patch:9.0.1685: silence Python 3.11 depreciations for gcc
vim-patch:9.0.1716: Windows build with python 3.12 and clang fails
vim-patch:9.0.1913: if_python: undefined behaviour for function pointers
vim-patch:9.0.1930: compiler warnings with clang-17
vim-patch:9.0.1971: macOS: FEAT_SOUND guard too restrictive

vim-patch:9.1.0066: gcc complains about use of uninitialized var
vim-patch:9.1.0067: gcc still complains about use of uninitialized var
vim-patch:9.1.0588: The maze program no longer compiles on newer clang
vim-patch:9.1.0827: CI: tests can be improved
vim-patch:9.1.0833: CI: recent ASAN changes do not work for indent tests
vim-patch:9.1.0846: debug symbols for xxd are not cleaned in Makefile
vim-patch:9.1.0884: gcc warns about uninitialized variable
vim-patch:9.1.0946: cross-compiling fails on osx-arm64
vim-patch:9.1.1189: if_python: build error due to incompatible pointer types
vim-patch:9.1.1347: small problems with gui_w32.c
vim-patch:9.1.1358: if_lua: compile warnings with gcc15
vim-patch:9.1.1365: MS-Windows: compile warnings and too many strlen() calls
vim-patch:9.1.1686: if_ruby: unknown pragma when not using gcc
vim-patch:9.1.1729: CI is not run with clang 21


8.1.1989 is N/A because of 8.2.0256 will move the time-related functions again. The rest of the patch became N/A due to partial patches.
9.1.0827 could be relevant for future patches that use the following but we started discussion on removing runtime/ test files in #35911.

func RunningAsan()
  return exists("$ASAN_OPTIONS")
endfunc

func ValgrindOrAsan()
  return RunningWithValgrind() || RunningAsan()
endfun

@zeertzjq
Copy link
Member

zeertzjq commented Sep 17, 2025

vim-patch:9.1.1765: f_isnan() and f_isinf() do not correctly initialize rettv type
vim-patch:9.1.1767: Patch v9.1.1765 was wrong
vim-patch:9.1.1812: completion: flicker with slow LSPs
vim-patch:9.1.1814: Patch v9.1.1812 causes crashes

@github-actions github-actions bot force-pushed the marvim/ci-version-update branch 6 times, most recently from c9e44df to d92c098 Compare September 23, 2025 03:19
@zeertzjq zeertzjq closed this Sep 23, 2025
@zeertzjq zeertzjq reopened this Sep 23, 2025
@github-actions github-actions bot force-pushed the marvim/ci-version-update branch 7 times, most recently from e67a247 to a35b2c2 Compare September 30, 2025 03:23
@github-actions github-actions bot force-pushed the marvim/ci-version-update branch 8 times, most recently from b85c129 to e0e3a80 Compare October 8, 2025 03:19
@github-actions github-actions bot force-pushed the marvim/ci-version-update branch from e0e3a80 to b4dc2ca Compare October 9, 2025 03:21
@janlazo
Copy link
Contributor

janlazo commented Oct 9, 2025

Is it normal for version.c PR to remain unmerged for awhile?

  • v8.1.1939: code for handling v: variables in generic eval file
  • v8.1.1979: code for handling file names is spread out
  • v8.1.1985: code for dealing with paths is spread out
  • v8.1.2022: the option.c file is too big

is still planned for a future version.c PR.

Are my suggestions in review?
I can add more since v8.2.x has many compiler-related patches.

@justinmk
Copy link
Member

justinmk commented Oct 9, 2025

Are my suggestions in review?

no just didn't realize it had been 3 weeks :)

@github-actions github-actions bot force-pushed the marvim/ci-version-update branch from b4dc2ca to 90887c2 Compare October 10, 2025 03:21
@justinmk justinmk marked this pull request as ready for review October 10, 2025 03:30
@github-actions github-actions bot requested a review from zeertzjq October 10, 2025 03:30
@justinmk justinmk merged commit 56713ef into master Oct 10, 2025
4 of 5 checks passed
@justinmk justinmk deleted the marvim/ci-version-update branch October 10, 2025 03:30
@github-actions github-actions bot removed the request for review from zeertzjq October 10, 2025 03:30
@justinmk
Copy link
Member

justinmk commented Oct 10, 2025

Did not include the 8.1.x items from #35753 (comment)

@janlazo
Copy link
Contributor

janlazo commented Oct 10, 2025

Did not include the 8.1.x items from #35753 (comment)

Right. I plan to port them. They're not N/A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vim-patch See https://neovim.io/doc/user/dev_vimpatch.html

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants