fix(api): on_bytes event reports incorrect end positions #36036
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The on_bytes event does not report the correct end positions when a line is deleted. Solution: Add a failing test case that demonstrates the incorrect behavior. The test is marked with FIXME comments that show the expected (correct) values.
justinmk
reviewed
Oct 11, 2025
| local eq = t.eq | ||
| local api = n.api | ||
|
|
||
| describe('API: on_bytes event', function() |
There was a problem hiding this comment.
the buf_attach tests live here:
|
The test doesnt fail so I assume you are still working on this? |
|
Hi, there's a bigger issue where, when I'm not sure what the correct behavior is so I haven't been able to make progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35557