Skip to content

njs: Update for version 0.9.0 API changes #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

njs: Update for version 0.9.0 API changes #1611

merged 1 commit into from
May 14, 2025

Conversation

ac000
Copy link
Member

@ac000 ac000 commented May 8, 2025

njs: Update for version 0.9.0 API changes

This bumps the minimum required version of njs to 0.9.0

Cc: Sergey A. Osokin <[email protected]>
Signed-off-by: Andrew Clayton <[email protected]>

@osokin
Copy link
Contributor

osokin commented May 8, 2025

Hi Andrew, that looks good to me.

Thank you very much for the review and the update! Much appreciate it!

@thresheek
Copy link
Member

We'd also need to bump njs in pkg/contrib as soon as this lands. I can prepare a patch, it's fairly trivial.

This bumps the minimum required version of njs to 0.9.0

Cc: Sergey A. Osokin <[email protected]>
Signed-off-by: Andrew Clayton <[email protected]>
@ac000
Copy link
Member Author

ac000 commented May 8, 2025

@thresheek

Yeah, I had bumped the version file, now also bumped the checksum file...

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request May 11, 2025
The patches applied to the www/unit are based on
nginx/unit#1611

Thanks to:	Andrew Clayton <[email protected]>

<ChangeLog>

 Core:

 *) Feature: refactored working with built-in strings, symbols
    and small integers.
    Performance improvements (arewefastyet/benchmarks/v8-v7 benchmark):
    Richards: +57% (631 → 989)
    Crypto: +7% (1445 → 1551)
    RayTrace: +37% (562 → 772)
    NavierStokes: +20% (2062 → 2465)
    Overall score: +29% (1014 → 1307)

*) Bugfix: fixed regexp undefined value of captured group.

*) Bugfix: fixed GCC 15 build with -Wunterminated-string-initialization.

</ChangeLog>
koobs pushed a commit to koobs/ports that referenced this pull request May 13, 2025
The patches applied to the www/unit are based on
nginx/unit#1611

Thanks to:	Andrew Clayton <[email protected]>

<ChangeLog>

 Core:

 *) Feature: refactored working with built-in strings, symbols
    and small integers.
    Performance improvements (arewefastyet/benchmarks/v8-v7 benchmark):
    Richards: +57% (631 → 989)
    Crypto: +7% (1445 → 1551)
    RayTrace: +37% (562 → 772)
    NavierStokes: +20% (2062 → 2465)
    Overall score: +29% (1014 → 1307)

*) Bugfix: fixed regexp undefined value of captured group.

*) Bugfix: fixed GCC 15 build with -Wunterminated-string-initialization.

</ChangeLog>
@ac000 ac000 marked this pull request as ready for review May 13, 2025 15:16
@ac000 ac000 requested review from hongzhidao and thresheek May 13, 2025 15:17
Copy link
Contributor

@hongzhidao hongzhidao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks for the upgrade.

Copy link
Member

@thresheek thresheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto/ and pkg/ part seems correct to me!

@ac000 ac000 merged commit 7e1f4a7 into nginx:master May 14, 2025
25 checks passed
@ac000 ac000 deleted the njs branch May 14, 2025 15:51
@ac000
Copy link
Member Author

ac000 commented May 14, 2025

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants