-
Notifications
You must be signed in to change notification settings - Fork 352
njs: Update for version 0.9.0 API changes #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac000
commented
May 8, 2025
Hi Andrew, that looks good to me. Thank you very much for the review and the update! Much appreciate it! |
We'd also need to bump njs in |
This bumps the minimum required version of njs to 0.9.0 Cc: Sergey A. Osokin <[email protected]> Signed-off-by: Andrew Clayton <[email protected]>
Yeah, I had bumped the version file, now also bumped the checksum file... |
The patches applied to the www/unit are based on nginx/unit#1611 Thanks to: Andrew Clayton <[email protected]> <ChangeLog> Core: *) Feature: refactored working with built-in strings, symbols and small integers. Performance improvements (arewefastyet/benchmarks/v8-v7 benchmark): Richards: +57% (631 → 989) Crypto: +7% (1445 → 1551) RayTrace: +37% (562 → 772) NavierStokes: +20% (2062 → 2465) Overall score: +29% (1014 → 1307) *) Bugfix: fixed regexp undefined value of captured group. *) Bugfix: fixed GCC 15 build with -Wunterminated-string-initialization. </ChangeLog>
The patches applied to the www/unit are based on nginx/unit#1611 Thanks to: Andrew Clayton <[email protected]> <ChangeLog> Core: *) Feature: refactored working with built-in strings, symbols and small integers. Performance improvements (arewefastyet/benchmarks/v8-v7 benchmark): Richards: +57% (631 → 989) Crypto: +7% (1445 → 1551) RayTrace: +37% (562 → 772) NavierStokes: +20% (2062 → 2465) Overall score: +29% (1014 → 1307) *) Bugfix: fixed regexp undefined value of captured group. *) Bugfix: fixed GCC 15 build with -Wunterminated-string-initialization. </ChangeLog>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thanks for the upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auto/ and pkg/ part seems correct to me!
Thanks guys! |